Feat: add eslint command for generated test file #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it will be cleaner here to use eslint class instead of shelling out to call it on command line. It also gives you more control and separates it from the project’s eslint configuration. see here: https://eslint.org/docs/latest/integrate/nodejs-api#eslint-class |
|
Oh I like that solution instead! Thanks for the link I'll look into it |
|
I'll most likely be able to get to this in the next couple weeks, I plan to make the suggested changes =) |
|
I've been busy sorry, I don't plan to dive into this again for another month or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps to ensure that the test file is formatted correctly for given project instead of trying to figure out formatting code myself.