refactor(VM-202): Eliminate duplication between speak-only and conversation modes - #110
Merged
Merged
Conversation
…sation modes Unified the TTS execution flow in converse() function by: - Deleted duplicate speak-only block (lines 1124-1279) - Created single unified flow with conditional STT execution - Added early return for speak-only mode after TTS success - Fixed error handling to properly support mock tests Results: - Reduced function from 1722 to 1602 lines (120 lines eliminated) - Zero code duplication between modes - All tests pass unchanged - Both modes work identically to before This simplifies the codebase and will make the repeat-phrase feature branch much easier to merge. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
marc-shade
pushed a commit
to marc-shade/voicemode
that referenced
this pull request
Feb 2, 2026
…-duplication-in-converse refactor(VM-202): Eliminate duplication between speak-only and conversation modes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unified the TTS execution flow in converse() function by:
Results:
This simplifies the codebase and will make the repeat-phrase feature branch much easier to merge.
🤖 Generated with Claude Code