Skip to content
This repository has been archived by the owner on Oct 23, 2021. It is now read-only.

I18n fixes #60

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

I18n fixes #60

wants to merge 3 commits into from

Conversation

louy
Copy link

@louy louy commented Apr 22, 2015

Making the plugin easier to translate and use in multi-lingual installs by removing duplicate labels for each post type/taxonomy.

@mboynes
Copy link
Owner

mboynes commented Apr 22, 2015

This is a good move. There's still a fundamental flaw to this plugin with regards to localization, and I don't really have an answer for it. That is, the "singular" and "plural" words derived from the object's slug, both of which assume english. Any thoughts on that? Otherwise, your translation is going to end up being something like, "Buscar Sponsored Articles"

@louy
Copy link
Author

louy commented Apr 22, 2015

Well, it's not your job to localize everything.
With the edits I suggest, the users will always have to name singulars/plurals themselves.

In the end, you can use the api like new Super_Custom_Post_Type('book', __('Book'), __('Books')); and end up with "Neues Buch", "Yeni Kitap" and "كتاب جديد" and you'll only have to translate 2 strings.

I guess the real issue is with capital/small letters (nouns in German are always capital) and masculine/feminine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants