[devcontainers] Handle external workspace + ubuntu noble #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arntanguy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the devcontainers to mount the files generated by the superbuild to a workspace folder outside of the cloned superbuild folder.
By default:
mc-rtc-superbuildmounts to/home/vscode/superbuild$HOME/docker-ws/mc-rtc-superbuild-<distro>mounts tohome/vscode/workspaceTo keep things consistent between docker and non-docker setups, the
CMakePresetsare set up to aways use<mc-rtc-superbuild folder>/../workspaceas the source/build directory. Within docker this maps to$HOME/docker-ws/mc-rtc-superbuild-<distro>on the host system.Additionally this adds a devcontainer setup for ubuntu noble. This is built without python support for the time being, pending jrl-umi3218/mc_rtc#469 or an upgrade to the existing bindings, whichever comes first.