Lowercase 'of' in custom potion names to match vanilla - #5338
Open
RasmusKD wants to merge 1 commit into
Open
Conversation
Vanilla potions display as 'Potion of X' but every custom potion in potions.yml says 'Potion Of X'. All 90 names now match the vanilla capitalization. Purely cosmetic: recipe matching compares effects, base type and lore, never display names, so existing brewed potions still match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vanilla potions display as 'Potion of Fire Resistance', but every custom potion in potions.yml displays as 'Potion Of Haste'. This lowercases the 90 names to match vanilla capitalization.
Purely cosmetic and safe for existing worlds: recipe matching (AlchemyPotion.isSimilarPotion) compares item type, effects, base potion type and lore, never display names, so already-brewed potions still match their recipes.