Conversation
Exercises two key things: - Calling process an extra time between messages - Checking the returned updated index on upload, which shouldn't be set because uploads don't update the object value
When process was called without a pending SdoRequest (a normal occurrence) the DownloadSegmented state was returned instead of UploadSegmented. This can result in an incorrect abort with AbortCode 0x5040001 / InvalidCommandSpecifier
Uploads are reads, they don't update the object so this should not be returned.
mcbridejc
force-pushed
the
fix-sdo-server-bugs
branch
from
1e4186e to
6ba22c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues, one major, one minor: