fix : build failed on mac / win#63
Merged
mcbridejc merged 2 commits intomcbridejc:mainfrom Apr 22, 2026
Merged
Conversation
Owner
|
Thanks for this. I thought: better run the build on macos to make sure it doesn't break again! Now I just need to somehow remove, or noop the zencan-cli crate on non-linux platforms... |
They will build, but only print error messages when run.
mcbridejc
force-pushed
the
zencan-client-upgrade
branch
from
30157b7 to
c88bf08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR enables zencan-client to compile on macOS and Windows.
Currently, the client is tied to SocketCAN, which restricts it to Linux. Since the existing abstraction is already quite clean, this PR only introduces minimal changes:
This keeps the existing behavior on Linux unchanged, while allowing other platforms to use different CAN interfaces (e.g., USB-CAN).
Feedback is welcome!