Skip to content

Adding LinkedIn to the council profile #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
notkaramel merged 3 commits into from
Feb 15, 2026
Merged

Adding LinkedIn to the council profile #106

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73efb6b
Adding LinkedIn to the council profile
notkaramel Feb 11, 2026
1b6e549
Make cursor become pointer when clicking X
notkaramel Feb 11, 2026
e80ca2d
LinkedIn fill and stroke
notkaramel Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ h1 {
}

h2 {
@apply py-3 text-xl font-bold md:text-2xl;
@apply py-1.5 text-xl font-bold md:text-2xl;
}

.page-title {
Expand Down
46 changes: 33 additions & 13 deletions src/components/council/CouncilCardPopUp.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@
positionDescription,
yearProgram,
image,
linkedin,
onClose,
id = 'popup-title'
} = $props();
import { Mail, X } from '@lucide/svelte';
import { Linkedin, Mail, X } from '@lucide/svelte';
import Link from 'components/Link.svelte';

function getInitials(name: string | null | undefined): string {
if (name == null || typeof name !== 'string') return '';
Expand Down Expand Up @@ -70,9 +72,11 @@
</div>

<!-- Information: below photo on small, right on md+ -->
<div class="flex min-w-0 flex-1 flex-col justify-center p-4 md:p-6">
<h2 {id} class="text-ecsess-50 text-lg leading-tight font-bold md:text-2xl">{name}</h2>
<p class="text-ecsess-200 -mt-0.5 text-sm italic md:text-base">{position}</p>
<div class="flex min-w-0 flex-1 flex-col justify-center p-0 px-4 md:p-6">
<div class="flex flex-wrap items-center justify-center gap-2">
<h2 {id} class="text-ecsess-50 mt-2 text-lg leading-tight font-bold md:text-2xl">{name}</h2>
</div>
<p class="text-ecsess-200 mt-0.5 text-sm italic md:text-base">{position}</p>

{#if positionDescription}
<div class="border-ecsess-700/60 mt-3 border-t pt-3 md:mt-4 md:pt-4">
Expand All @@ -82,17 +86,33 @@
</div>
{/if}

{#if email}
{#if email || linkedin}
<div
class="border-ecsess-700/60 mt-3 flex flex-row items-center justify-center gap-2 border-t pt-3 text-center md:mt-4 md:pt-4"
class="border-ecsess-700/60 mt-2 mb-4 flex flex-col items-center justify-center gap-1 border-t pt-3 text-center md:mb-0 md:pt-4"
>
<Mail class="text-ecsess-300 size-4 shrink-0" aria-hidden="true" />
<a
href="mailto:{email}"
class="text-ecsess-200 decoration-ecsess-500 hover:text-ecsess-50 hover:decoration-ecsess-400 text-sm font-medium break-all underline underline-offset-2 md:text-base"
>
{email}
</a>
{#if email}
<div class="flex items-center justify-center gap-2">
<Mail class="text-ecsess-300 size-4 shrink-0" aria-hidden="true" />
<a
href="mailto:{email}"
class="text-ecsess-200 decoration-ecsess-500 hover:text-ecsess-50 hover:decoration-ecsess-400 text-sm font-medium break-all underline underline-offset-2 md:text-base"
>
{email}
</a>
</div>
{/if}
{#if linkedin}
<div class="flex items-center justify-center gap-2">
<Linkedin class="stroke-ecsess-400 size-4 stroke-2" aria-hidden="true" />
Copy link
Contributor

@MinhVo2005 MinhVo2005 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add fill="white" cuz the filling is empty for the icon

Copy link
Member Author

@notkaramel notkaramel Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lucide icon filling is empty by default :(

Copy link
Contributor

@MinhVo2005 MinhVo2005 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea but u can add filling in. I did that for the footer linkedIn logo. It's just me being picky bleh

<Link
href={linkedin}
external
class="text-ecsess-200 decoration-ecsess-500 hover:text-ecsess-50 hover:decoration-ecsess-400 text-sm font-medium break-all underline underline-offset-2 md:text-base"
>
LinkedIn
</Link>
</div>
{/if}
</div>
{/if}
</div>
Expand Down
1 change: 1 addition & 0 deletions src/lib/schemas.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ export type CouncilMember = {
positionDescription: string;
image: string; // URL
yearProgram: string;
linkedin?: string; // URL to profile, optional
};

export type Resource = {
Expand Down
3 changes: 2 additions & 1 deletion src/routes/council/+page.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ const councilQuery = `{
position,
positionDescription,
"image": image.asset->url+"?h=360&fm=webp",
yearProgram
yearProgram,
linkedin
},
"councilGoofyPic": *[_type == "homepage"]{
"url": councilGoofyPic.asset->url+"?h=1200&fm=webp"
Expand Down
1 change: 1 addition & 0 deletions src/routes/council/+page.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@
positionDescription={selectedMember.positionDescription}
yearProgram={selectedMember.yearProgram}
image={selectedMember.image}
linkedin={selectedMember.linkedin}
onClose={closeModal}
/>
</div>
Expand Down