Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused CSS class #74

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Remove unused CSS class #74

merged 2 commits into from
Feb 19, 2024

Conversation

jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented Feb 15, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Removed an unused CSS class that was perhaps originally meant to be used for the ETASU button's MUI 5 ListIcon, which only uses words for fontSize and not a numerical pixel value. The ListIcon already uses a fontSize of 'large' and this class isn't used anywhere else.

image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

N/A but found while doing https://jira.mitre.org/secure/RapidBoard.jspa?rapidView=4984&projectKey=REMS&view=detail&selectedIssue=REMS-597, while copying over CSS stylesheets from rems-smart-on-fhir

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@avirgulto avirgulto merged commit ccb9b54 into dev Feb 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants