Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard etasu endpoint #84

Merged
merged 7 commits into from
Apr 8, 2024
Merged

use standard etasu endpoint #84

merged 7 commits into from
Apr 8, 2024

Conversation

KeeyanGhoreshi
Copy link
Contributor

Describe your changes

Makes use of the standard etasu endpoint on the rems server, replacing old format with new FHIR GuidanceResponse format. Nothing should functionally change other than a couple bits of data being changed or removed, like the case number not showing in the UI anymore or the change in the status language.

Issue ticket number and Jira link

REMS-620

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

@plarocque4
Copy link
Contributor

The GuidanceResponse $rems-etasu operation is looking for a Medication resource not a MedicationRequest. Could you please create a Medication resource and send that instead.

@plarocque4 plarocque4 self-assigned this Apr 5, 2024
@KeeyanGhoreshi
Copy link
Contributor Author

Is it looking for a medication resource by standard? The PR I made in rems-admin handles med requests.

@plarocque4
Copy link
Contributor

plarocque4 commented Apr 5, 2024

It appears that you didn't update the query that is sent from the page returned from completion of the Patient Enrollment Form. We either need to update this as well or remove the ETASU check from that page.

plarocque4
plarocque4 previously approved these changes Apr 8, 2024
Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well

@plarocque4 plarocque4 merged commit a10a8c4 into dev Apr 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants