CDS Hook Cards UI Updates #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine and works as is, the only thing I'll mention is that I think we could maybe get it to look a little nicer by adopting a more "square" look for the card internals, to avoid stacking all the options on top of each other. When the cards are side by side, they have a difference in height of components so you're left with a big gap on the bottom of one of them, for example: It might look a bit more homogenous if we have them square so they line up into the same row. I'm also a big proponent of getting rid of the "Add ____ to task list" from the task buttons if they're going to be under a section called "Add to task list". |
|
just needs linting errors fixed |
plarocque4
reviewed
May 17, 2024
plarocque4
previously approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Updated CDS Hooks Card UI based off of mockup styling.
Old:
Updated:
Issue ticket number and Jira link
REMS-579
Checklist before requesting a review
devnot main (the only exception to this is releases fromdevand hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.