-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquid layout #89
Liquid layout #89
Conversation
…r screens is fully visible
…e no longer displays it
…text indentation based on screen size, and remove closing tag on childless component
…er option when clicking the load previous form button
…oad it, fix bug where form would still display New when selecting Cancel, and consolidate state into reducer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merge Conflicts need to be addressed
src/views/Questionnaire/components/RemsInterface/RemsInterface.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you load a previous form, then modify it, then try to save it to the ehr, it reverts your form back to the previously loaded version, erasing any progress.
Thanks for catching that, should be fixed now |
Describe your changes
This PR implements WCAG techniques G146, G179, G199
It turns out LForms actually has built in display options for small, medium, and large screen sizes if one clicks the settings cog icon and selects an option from the View Mode dropdown. So that also already covers G146 and G179 on the QuestionnaireForm page.
Default breakpoints in MUI 5 to reference for below
Before - Home page with patient view and medication select dropdown
xs screen (problematic)
sm screen (problematic at breakpoint, but otherwise OK)
md screen (problematic horizontal scroll bar on patient view, but this is just above the sm-md breakpoint)
lg screen (OK)
After - Home page
xs screen (after pre-wrapping whitespace, fixing ETASU/MedicationDispense.status text spacing, and text-wrapping MedicationRequest dropdown)
sm screen (after fixing ETASU/MedicationDispense.status text spacing)
md screen (after pre-wrapping whitespace)
Before - Document Status
Applies to all screen sizes xs, sm, md, lg - horizontal scrollbar for FHIR Resource JSON inside
<pre>
tagAfter - Document Status
Before - QuestionnaireResponse form launched from within REMS SMART on FHIR app
xs screen (problematic cut-off text with input fields' helper text and values)
After - QuestionnaireResponse form
xs screen (no padding)
sm screen and above (original padding)
Issue ticket number and Jira link
https://jira.mitre.org/browse/REMS-654
Checklist before requesting a review
dev
not main (the only exception to this is releases fromdev
and hotfix branches)Checklist for conducting a review
Workflow
Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.