Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid layout #89

Merged
merged 26 commits into from
May 21, 2024
Merged

Liquid layout #89

merged 26 commits into from
May 21, 2024

Conversation

jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented Apr 18, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

This PR implements WCAG techniques G146, G179, G199

  • Liquid layout
  • no loss of content or functionality when zooming in
  • indication of form submission success (existing for submitting REMS bundle, but fixed bug with form loading)

It turns out LForms actually has built in display options for small, medium, and large screen sizes if one clicks the settings cog icon and selects an option from the View Mode dropdown. So that also already covers G146 and G179 on the QuestionnaireForm page.

Default breakpoints in MUI 5 to reference for below


Before - Home page with patient view and medication select dropdown

xs screen (problematic)

image
image

sm screen (problematic at breakpoint, but otherwise OK)

image
image

md screen (problematic horizontal scroll bar on patient view, but this is just above the sm-md breakpoint)

present content without introducing horizontal scroll bars

image
image

lg screen (OK)

image
image

After - Home page

xs screen (after pre-wrapping whitespace, fixing ETASU/MedicationDispense.status text spacing, and text-wrapping MedicationRequest dropdown)

image
image

sm screen (after fixing ETASU/MedicationDispense.status text spacing)

image

md screen (after pre-wrapping whitespace)

image


Before - Document Status

Applies to all screen sizes xs, sm, md, lg - horizontal scrollbar for FHIR Resource JSON inside <pre> tag

image

image

image

image

After - Document Status

image

image

image

image


Before - QuestionnaireResponse form launched from within REMS SMART on FHIR app

xs screen (problematic cut-off text with input fields' helper text and values)

image

After - QuestionnaireResponse form

xs screen (no padding)

image image

sm screen and above (original padding)

image image

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

https://jira.mitre.org/browse/REMS-654

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@jtquach1 jtquach1 marked this pull request as ready for review May 6, 2024 15:18
@jtquach1 jtquach1 changed the title WIP: Liquid layout Liquid layout May 6, 2024
@zacharyrobin zacharyrobin self-assigned this May 7, 2024
Copy link
Contributor

@zacharyrobin zacharyrobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge Conflicts need to be addressed

Copy link
Contributor

@KeeyanGhoreshi KeeyanGhoreshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you load a previous form, then modify it, then try to save it to the ehr, it reverts your form back to the previously loaded version, erasing any progress.

@jtquach1
Copy link
Contributor Author

When you load a previous form, then modify it, then try to save it to the ehr, it reverts your form back to the previously loaded version, erasing any progress.

Thanks for catching that, should be fixed now

@jtquach1 jtquach1 merged commit ef3cfe9 into dev May 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants