Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send hook depending on medication & handle multiple REMS admins with patient-view hook #95

Merged
merged 5 commits into from
May 23, 2024

Conversation

jtquach1
Copy link
Contributor

@jtquach1 jtquach1 commented May 20, 2024

Describe your changes

Please include a summary of the changes and the related issue/task. Please also include relevant motivation and context. List any dependencies that are required for this change, including links to other pull requests/branches in other repositories if applicable.

Changes

  • Added REMS admin lookup table and lookup logic from request-generator
  • Renamed some variables
  • Updated commit hash pointed to in src/cds-hooks

Related PRs

Issue ticket number and Jira link

Please include the Jira Ticket Number and Link for this issue/task.

REMS-660 and REMS-678

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

How to manually test this

  1. Use dev for all repos, except src/cds-hooks mentioned above
  2. Go to request-generator, authenticate, click "Launch SMART on FHIR app"
  3. Open network tab
  4. Note that 4 network requests were made to rems-patient-view and 4 responses were returned back
  5. If the Turalio Patient Enrollment Form has been completed, you should see 4 Patient Status Update Form cards (is this correct?)
  6. Otherwise, you will not see any cards

@plarocque4 plarocque4 self-assigned this May 21, 2024
@jtquach1 jtquach1 force-pushed the rems-admin-lookup-table branch from 66d376d to 3155775 Compare May 21, 2024 17:55
Copy link
Contributor

@plarocque4 plarocque4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@plarocque4 plarocque4 merged commit f7d6ef1 into dev May 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants