Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment and vite build #143

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Fix environment and vite build #143

merged 2 commits into from
Jan 6, 2025

Conversation

plarocque4
Copy link

Describe your changes

Changes needed to get the request generator to work with the MELD / Logica Sandboxes.
Build with vite.
Trim the environment variable specifying it is running on GitHub pages to remove spaces.

Issue ticket number and Jira link

REMS-767

Checklist before requesting a review

  • I have performed a self-review of my code
  • Ensure the target / base branch for any feature PR is set to dev not main (the only exception to this is releases from dev and hotfix branches)

Checklist for conducting a review

  • Review the code changes and make sure they all make sense and are necessary.
  • Pull the PR branch locally and test by running through workflow and making sure everything works as it is supposed to.

Workflow

Owner of the Pull Request will be responsible for merge after all requirements are met, including approval from at least one reviewer. Additional changes made after a review will dismiss any approvals and require re-review of the additional updates. Auto merging can be enabled below if additional changes are likely not to be needed. The bot will auto assign reviewers to your Pull Request for you.

@plarocque4 plarocque4 changed the title Connectathon 2025 01 2 Fix environment and vite build Jan 3, 2025
@plarocque4 plarocque4 requested a review from smalho01 January 3, 2025 18:48
@smalho01 smalho01 merged commit d688aef into dev Jan 6, 2025
1 check passed
@smalho01 smalho01 deleted the connectathon_2025-01_2 branch January 6, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants