mdadm: load md_mod first #228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Load md_mod first before setting module parameter legacy_async_del_gendisk Everything works well if md_mod is built in kernel. If not, create and assemble will fail. Fixes: d354d31 ("mdadm: Create array with sync del gendisk mode") Signed-off-by: Xiao Ni <[email protected]>
mtkaczyk
reviewed
Jan 7, 2026
| if (system("modprobe md_mod") == 0) | ||
| fd = open(new_array_file, O_WRONLY); | ||
| } | ||
| if (fd >= 0) { |
Member
There was a problem hiding this comment.
if (!is_fd_valid(fd)){
pr_err("Fail to open %s\n", new_array_file);
return 0;
}
n = write(fd, devnm, strlen(devnm));
close(fd);
if (n != (int)strlen(devnm)) {
Looks like simpler.
Collaborator
Author
There was a problem hiding this comment.
if (!is_fd_valid(fd)){ pr_err("Fail to open %s\n", new_array_file); return 0; } n = write(fd, devnm, strlen(devnm)); close(fd); if (n != (int)strlen(devnm)) {Looks like simpler.
Hi Mariusz
The codes mentioned above don't have relationship with this problem, right? You mean this part can be improved in this way, right?
Collaborator
Author
There was a problem hiding this comment.
Ok, I'll modify this in another PR for it.
ncroxon
approved these changes
Jan 13, 2026
mtkaczyk
approved these changes
Jan 13, 2026
bdrung
added a commit
to bdrung/dracut-ng
that referenced
this pull request
Jan 16, 2026
Tested with: ``` git-archive && sbuild -s --no-clean-source --run-autopkgtest ``` test results: waiting for md-raid-utilities/mdadm#228 to be merged into mdadm ``` lsinitrd PASS (superficial) 10-basic PASS 13-sysroot PASS 40-systemd PASS 42-systemd-initrd PASS 43-kernel-install PASS 80-getarg PASS 81-skipcpio PASS 11-usr-mount PASS 12-uefi PASS 20-storage FAIL non-zero exit status 2 26-enc-raid-lvm FAIL non-zero exit status 2 30-dmsquash PASS 41-full-systemd PASS 44-drivers PASS 50-network PASS 60-nfs PASS 70-iscsi FAIL non-zero exit status 2 71-iscsi-multi FAIL non-zero exit status 2 72-nbd PASS ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load md_mod first before setting module parameter legacy_async_del_gendisk Everything works well if md_mod is built in kernel. If not, create and assemble will fail.