Add dashed outline to checkbox checked state #40960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a dashed outline to the checked state of the question box so that color is not the only change (currently red/green change is not visible to 10% of the population)
estelle
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:CSS
|
Preview URLs Flaws (1)URL:
|
chrisdavidmills
requested changes
Sep 1, 2025
There was a problem hiding this comment.
LGTM, but you should also make the same change in the same example code found at https://developer.mozilla.org/en-US/docs/Web/API/CustomStateSet#matching_a_custom_state_in_a_shadow_part_of_a_custom_element, which is referenced from the page you have edited.
estelle
added a commit
that referenced
this pull request
Sep 3, 2025
|
see #40995 |
wbamberg
pushed a commit
that referenced
this pull request
Sep 4, 2025
chrisdavidmills
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a dashed outline to the checked state of the question box so that color is not the only change (currently red/green change is not visible to 10% of the population)