Fix composite transform order in animation-composition example#44431
Open
mao-sz wants to merge 1 commit into
Open
Fix composite transform order in animation-composition example#44431mao-sz wants to merge 1 commit into
animation-composition example#44431mao-sz wants to merge 1 commit into
Conversation
Contributor
|
Preview URLs (1 page) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation
The composite transform example in
animation-compositionoriginally described the process from left-to-right, with each transform establishing a new coordinate space. This was changed to the right-to-left order in #38561 because at the time, the docs fortransformwere worded such that it seemed that right-to-left was "the order" in practice.With #43496, the
transformdocs are much clearer on the different orders and respective behaviours with coordinate space, and uses the left-to-right order as the primary one for explanation. Therefore, we can return theanimation-compositionexample to how it was before.Additional details
Current
transformdocsRelated issues and pull requests
N/A