Skip to content

A fix for collections and collection streaming #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mjbosher wants to merge 7 commits into
base: master
Choose a base branch
from
Open

A fix for collections and collection streaming #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
334872b
added id to mock collection.id
Jan 30, 2025
06a796c
Fixed TypeError with stream where object comparisons werent possible …
Jan 30, 2025
739a69c
test
Jan 31, 2025
ac1a4da
changed version in test.yml
Jan 31, 2025
a681861
changed image to ubunto to 22.04
Jan 31, 2025
ddbc378
Removed 3.6 from testing as not supported GHA anymore
Jan 31, 2025
00cd182
Removed python 3.7 from GHA as unsupported
Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: [ '3.6', '3.7', '3.8', '3.9', '3.10' ]
python-version: [ '3.8', '3.9', '3.10', '3.11', '3.12']

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v2
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,4 @@ transaction.commit()
* [William Li](https://github.com/wli)
* [Ugo Marchand](https://github.com/UgoM)
* [Bryce Thornton](https://github.com/brycethornton)

5 changes: 4 additions & 1 deletion mockfirestore/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ def __init__(self, data: Store, path: List[str],
self._data = data
self._path = path
self.parent = parent
self.id = None
if len(path):
self.id = path[0]

def document(self, document_id: Optional[str] = None) -> DocumentReference:
collection = get_by_path(self._data, self._path)
Expand Down Expand Up @@ -80,6 +83,6 @@ def list_documents(self, page_size: Optional[int] = None) -> Sequence[DocumentRe
return docs

def stream(self, transaction=None) -> Iterable[DocumentSnapshot]:
for key in sorted(get_by_path(self._data, self._path)):
for key in sorted({str(k):v for k,v in get_by_path(self._data, self._path).items()}):
doc_snapshot = self.document(key).get()
yield doc_snapshot