Open
Conversation
An unhandled error from term.MakeRaw results in nil raw being passed to deferred term.Restore, which panics when the function returns
Author
|
Hi there @mdp, I'm sure you're quite busy with other things but I would appreciate a moment of your time to take a look here, if you're able to spare one! Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
I have been using qrterminal for some time and it is great! Recently I updated to 3.2.1 and I am experiencing a panic on Windows Terminal with Git Bash.
This is caused by an unhandled error in
IsSixelSupported.This PR adds the missing error handling.
I am not sure whether it is feasible to add a test since it is environment specific, but please let me know if you would like any further changes. Thanks!