Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
==========================================
- Coverage 13.77% 13.48% -0.30%
==========================================
Files 7 7
Lines 4145 4376 +231
==========================================
+ Hits 571 590 +19
- Misses 3574 3786 +212 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
16 tasks
16 tasks
16 tasks
…larger than figure region
…min_max, set_cmap, plot_3d, grd_compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable plotting functions for grids of other projections than just EPSG 3031 and 3413. This will add an additional parameter epsg to all user-facing functions, so users can provide either the hemisphere or the EPSG code directly. For all private functions, all hemisphere parameters will be replaced with the epsg parameter. This shouldn't break anything, as hemisphere can be provided as in the past, but internally will be converted to the relevant EPSG code.
This allows plotting functions such as
add_coastline,add_simple_basemap, andadd_insetto work with other regions.PolarToolkit will still be focused on polar regions, but allowing some of these plotting functions to work with other regions means the convenient and quick plotting from PolarToolkit can be used in other regions.