fix: unable to update content with async resolveData function #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@do4Mother is attempting to deploy a commit to the Measured Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chrisvxd
reviewed
Feb 12, 2025
There was a problem hiding this comment.
Hey @do4Mother! Thank you so much for your contribution (and flattered that it's your first ever).
Unfortunately this function is quite intentionally setup to avoid race conditions caused by Zustand and React rendering out of sync. I think your fix is likely to cause other issues, so I'm going to have to debug #876 myself further.
I'll leave this PR open, and if it's the correct fix, go with your contribution 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is first time i made contribution in open source project. please let me know if i made some mistake. 😄
so i have an issue regarding #876, when i tried to debugging.
contentWithPreviewvariable didn't update correctly if inserting component with async resolveData function.