Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: placeholder param for text, textarea, number fields #881

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

DamianKocjan
Copy link
Contributor

Closes: #833

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 11:07am
puck-docs ✅ Ready (Inspect) Visit Preview Feb 12, 2025 11:07am

Copy link

vercel bot commented Feb 6, 2025

@DamianKocjan is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution, thank you!

Couple of minor comments. Since this is a feature, I may hold off merging until we're closer to 0.19.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Great! Will hold off merge until closer to feature release.

@chrisvxd chrisvxd merged commit 32a6f78 into measuredco:main Feb 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add placeholder param to text, textarea, number fields
2 participants