Add OnlineNewsMediaCloudESProvider.random_sample method & tests #47
+213
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provider.py: * Declare AllItems to be Iterable[Items] * Add a comment on "sample" not being random! * Add random_sample!! * Use random_sample in _sample_titles (safe since deprecated providers being removed) onlinenews.py: * Update/correct comments * Raised some questions in comments! * Renamed "Field" TypeAlias to ES_Field, add ES_Fields * Allow floating FilterTuple weight * Merged _sanitize functionality into SanitizedQuery * Have random_sample return AllItems, use yield
philbudne
changed the title
|
Less drafty!! |
https://meag.sentry.io/issues/6275421536/?project=6781815 'Hit' object has no attribute 'article_title'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First draft, for your consideration...
Adds a new random_sample method (by extending the existing code used to sample titles) with a required fields=["field1", "field2"] which determines the fields returned.
I could almost certainly tuck the functionality into the existing
samplemethod if the fields argument isn't passed, callsuper().sample(....)which will return the (possibly not so random)hitsfrom the overview query.Then, if web-search passed a fields list in the
/api/search/sampleendpoint the new (separate) query would be used for the sample stories for a search...