Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove siteinfo check #244

Closed
wants to merge 2 commits into from
Closed

Remove siteinfo check #244

wants to merge 2 commits into from

Conversation

sian1468
Copy link

@sian1468 sian1468 commented Jun 6, 2024

Ref: #240

Remove siteinfo check as unnecessary to test this function and this code also hard to maintain in long term.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@sian1468
Copy link
Author

sian1468 commented Jun 6, 2024

@yzqzss

If you have any idea to fix this problem, feel free to comment here or create a new PR.

Copy link
Member

@robkam robkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix but I can't see how removing the test it fails being the correct solution.
Now fixed with #245 (until a way around the hardcoded version number is available).

@robkam robkam closed this Jun 13, 2024
@sian1468 sian1468 deleted the siteinfo branch June 13, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants