Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read document ids from downloaded files in github integration tests #428

Closed
michael-82 opened this issue Jan 15, 2025 · 0 comments · Fixed by #429
Closed

Read document ids from downloaded files in github integration tests #428

michael-82 opened this issue Jan 15, 2025 · 0 comments · Fixed by #429
Assignees
@michael-82
Labels
enhancement New feature or request

Comments

@michael-82
Copy link
Collaborator

The integration test that reads documents by id in github actions currently uses fixed ids. Those ids change with new ontology files which always leads to errors.
Extract some of the ids from the downloaded files and use them to conduct the tests.
@michael-82 michael-82 added the enhancement New feature or request label Jan 15, 2025
@michael-82 michael-82 self-assigned this Jan 15, 2025
michael-82 added a commit that referenced this issue Jan 15, 2025
@michael-82
#428 - Read document ids from downloaded files in github integration …
2c36f82 
…tests

- use grep/awk to extract the first id from an ontology and a codeable_concept file to use for checks
michael-82 added a commit that referenced this issue Jan 15, 2025
@michael-82
#428 - Read document ids from downloaded files in github integration …
659f096 
…tests

- use grep/awk to extract the first id from an ontology and a codeable_concept file to use for checks
@michael-82 michael-82 linked a pull request Jan 15, 2025 that will close this issue
#428 - Read document ids from downloaded files in github integration tests #429
Merged
michael-82 added a commit that referenced this issue Jan 15, 2025
@michael-82
#428 - Read document ids from downloaded files in github integration …
a64afdc 
…tests

- use grep/awk to extract the first id from an ontology and a codeable_concept file to use for checks
michael-82 added a commit that referenced this issue Jan 15, 2025
@michael-82
#428 - Read document ids from downloaded files in github integration …
cb750fc 
…tests

- use grep/awk to extract the first id from an ontology and a codeable_concept file to use for checks
michael-82 added a commit that referenced this issue Jan 15, 2025
@michael-82
#428 - Read document ids from downloaded files in github integration …
490191a 
…tests

- use grep/awk to extract the first id from an ontology and a codeable_concept file to use for checks
michael-82 added a commit that referenced this issue Jan 16, 2025
@michael-82
Merge pull request #429 from medizininformatik-initiative/feature/428…
451a6f7 
…-read-document-ids-from-downloaded-files-in-github-integration-tests

#428 - Read document ids from downloaded files in github integration tests
@michael-82 michael-82 mentioned this issue Jan 24, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michael-82 michael-82

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@michael-82