Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#433 - Change endpoint /codeable-concept/entry/{id} to allow for multiple ids #435

Conversation

michael-82
Copy link
Collaborator

  • Endpoint is changed to /codeable-concept/entry, expecting a list of ids as query parameter
  • CodeableConceptEntry now included the id in the returned json

@michael-82 michael-82 added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 24, 2025
@michael-82 michael-82 self-assigned this Jan 24, 2025
@michael-82 michael-82 force-pushed the feature/433-change-endpoint-codeable-conceptentryid-to-allow-for-multiple-ids branch from 2f44936 to e1d20ad Compare January 24, 2025 08:29
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (ac2ae46) to head (c779765).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #435      +/-   ##
=============================================
+ Coverage      75.23%   75.26%   +0.02%     
- Complexity       578      579       +1     
=============================================
  Files            154      154              
  Lines           2592     2595       +3     
  Branches         228      228              
=============================================
+ Hits            1950     1953       +3     
  Misses           576      576              
  Partials          66       66              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-82 michael-82 force-pushed the feature/433-change-endpoint-codeable-conceptentryid-to-allow-for-multiple-ids branch from e1d20ad to 5711994 Compare January 24, 2025 09:08
@michael-82 michael-82 marked this pull request as ready for review January 24, 2025 09:26
@michael-82 michael-82 force-pushed the feature/433-change-endpoint-codeable-conceptentryid-to-allow-for-multiple-ids branch from 5711994 to c384cde Compare January 24, 2025 10:08
…iple ids

- Endpoint is changed to /codeable-concept/entry, expecting a list of ids as query parameter
- CodeableConceptEntry now included the id in the returned json
- Add 1 sec sleep after uploading testdata because there seems to be a timing issue
@michael-82 michael-82 force-pushed the feature/433-change-endpoint-codeable-conceptentryid-to-allow-for-multiple-ids branch from c384cde to c779765 Compare January 24, 2025 11:04
@michael-82 michael-82 merged commit a26f0c0 into develop Jan 24, 2025
8 checks passed
@michael-82 michael-82 deleted the feature/433-change-endpoint-codeable-conceptentryid-to-allow-for-multiple-ids branch January 24, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change endpoint /codeable-concept/entry/{id} to allow for multiple ids
2 participants