#374 - Extend api to save and load cohort and dataselection #459
+2,572
−3,114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #459 +/- ##
=============================================
+ Coverage 75.61% 75.75% +0.13%
+ Complexity 580 549 -31
=============================================
Files 154 150 -4
Lines 2633 2487 -146
Branches 229 214 -15
=============================================
- Hits 1991 1884 -107
+ Misses 576 540 -36
+ Partials 66 63 -3 ☔ View full report in Codecov by Sentry. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @DisplayName("getDataquerySlotsJson() -> succeeds") | ||
| void getDataquerySlotsJson_succeeds() throws JsonProcessingException { | ||
| var dataqueryHandler = createDataqueryHandler(); | ||
| var usedSlots = new Random().nextLong(); |
Check warning
Code scanning / CodeQL
Random used only once Warning test
michael-82
force-pushed
the
feature/374-extend-api-to-save-and-load-cohort-and-dataselection
branch
from
efd88c5 to
b4b7961
Compare
- move api to v5 - add Dataquery - remove query template and saved query - add database migration script - remove unused methods, exceptions and tests - update ontology tag in github integration test - modify swagger file - convert saved queries and templates to dataqueries in db migration
michael-82
force-pushed
the
feature/374-extend-api-to-save-and-load-cohort-and-dataselection
branch
from
f3d8e98 to
2428a6f
Compare
- remove some unused imports - fix some minor potential errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Templates and Saved queries.
Implement Dataqueries as discussed in the corresponding issue ( #374 )