-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix(dashboard): Added the __BASE__ prefix to the datatable row on click - FIXES 14117 #14118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: f937900 The changes in this PR will be included in the next version bump. This PR includes changesets to release 74 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@adevinwild is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
packages/admin/dashboard/src/components/data-table/data-table.tsx
Outdated
Show resolved
Hide resolved
…ath for new tab/window links
Summary
What — What changes are introduced in this PR?
Pushed a fix at the
DataTablelevel to take into account the base path when usingwindow.openWhy — Why are these changes relevant or necessary?
Without the base path in the URL, it will navigate to a non existent page
How — How have these changes been implemented?
By adding the base path as a prefix to the URL when using meta keys while clicking on a row
Testing — How have these changes been tested, or how can the reviewer test the feature?
view_configurationsFF, which will lead to the usage of configurable tableExamples
Checklist
Please ensure the following before requesting a review:
yarn changesetand follow the promptsAdditional Context
Related to :
#14117
Note
Ensures DataTable row clicks open correct URLs by prefixing
__BASE__(or/) when launching new tabs/windows.packages/admin/dashboard/src/components/data-table/data-table.tsxto prefix rowhrefwith__BASE__(or/) forwindow.openon meta/ctrl/middle-click and shift-click.@medusajs/dashboardas a patch.Written by Cursor Bugbot for commit f937900. This will update automatically on new commits. Configure here.