Skip to content

Conversation

@adevinwild
Copy link
Contributor

@adevinwild adevinwild commented Nov 25, 2025

Summary

What — What changes are introduced in this PR?

Pushed a fix at the DataTable level to take into account the base path when using window.open

Why — Why are these changes relevant or necessary?

Without the base path in the URL, it will navigate to a non existent page

How — How have these changes been implemented?

By adding the base path as a prefix to the URL when using meta keys while clicking on a row

Testing — How have these changes been tested, or how can the reviewer test the feature?

  • Enable view_configurations FF, which will lead to the usage of configurable table
  • Try to open a order or a product by maintaining the meta key or shift

Examples

  • N/A

Checklist

Please ensure the following before requesting a review:

  • I have added a changeset for this PR
    • Every non-breaking change should be marked as a patch
    • To add a changeset, run yarn changeset and follow the prompts
  • The changes are covered by relevant tests
  • I have verified the code works as intended locally
  • I have linked the related issue(s) if applicable

Additional Context

Related to :
#14117


Note

Ensures DataTable row clicks open correct URLs by prefixing __BASE__ (or /) when launching new tabs/windows.

  • Dashboard/UI:
    • Update packages/admin/dashboard/src/components/data-table/data-table.tsx to prefix row href with __BASE__ (or /) for window.open on meta/ctrl/middle-click and shift-click.
  • Release:
    • Add changeset marking @medusajs/dashboard as a patch.

Written by Cursor Bugbot for commit f937900. This will update automatically on new commits. Configure here.

@adevinwild adevinwild requested a review from a team as a code owner November 25, 2025 09:23
@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2025

🦋 Changeset detected

Latest commit: f937900

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 74 packages
Name Type
@medusajs/dashboard Patch
@medusajs/admin-bundler Patch
@medusajs/medusa Patch
@medusajs/test-utils Patch
@medusajs/medusa-oas-cli Patch
integration-tests-http Patch
@medusajs/analytics Patch
@medusajs/api-key Patch
@medusajs/auth Patch
@medusajs/caching Patch
@medusajs/cart Patch
@medusajs/currency Patch
@medusajs/customer Patch
@medusajs/file Patch
@medusajs/fulfillment Patch
@medusajs/index Patch
@medusajs/inventory Patch
@medusajs/link-modules Patch
@medusajs/locking Patch
@medusajs/notification Patch
@medusajs/order Patch
@medusajs/payment Patch
@medusajs/pricing Patch
@medusajs/product Patch
@medusajs/promotion Patch
@medusajs/region Patch
@medusajs/sales-channel Patch
@medusajs/settings Patch
@medusajs/stock-location Patch
@medusajs/store Patch
@medusajs/tax Patch
@medusajs/user Patch
@medusajs/workflow-engine-inmemory Patch
@medusajs/workflow-engine-redis Patch
@medusajs/draft-order Patch
@medusajs/oas-github-ci Patch
@medusajs/cache-inmemory Patch
@medusajs/cache-redis Patch
@medusajs/event-bus-local Patch
@medusajs/event-bus-redis Patch
@medusajs/analytics-local Patch
@medusajs/analytics-posthog Patch
@medusajs/auth-emailpass Patch
@medusajs/auth-github Patch
@medusajs/auth-google Patch
@medusajs/caching-redis Patch
@medusajs/file-local Patch
@medusajs/file-s3 Patch
@medusajs/fulfillment-manual Patch
@medusajs/locking-postgres Patch
@medusajs/locking-redis Patch
@medusajs/notification-local Patch
@medusajs/notification-sendgrid Patch
@medusajs/payment-stripe Patch
@medusajs/core-flows Patch
@medusajs/framework Patch
@medusajs/js-sdk Patch
@medusajs/modules-sdk Patch
@medusajs/orchestration Patch
@medusajs/types Patch
@medusajs/utils Patch
@medusajs/workflows-sdk Patch
@medusajs/cli Patch
@medusajs/deps Patch
@medusajs/telemetry Patch
@medusajs/admin-sdk Patch
@medusajs/admin-shared Patch
@medusajs/admin-vite-plugin Patch
@medusajs/icons Patch
@medusajs/toolbox Patch
@medusajs/ui-preset Patch
create-medusa-app Patch
medusa-dev-cli Patch
@medusajs/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 25, 2025

@adevinwild is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@adevinwild adevinwild changed the title Fix issue 14117 Dashboard: Added the __BASE__ prefix to the datatable row on click Nov 25, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@adevinwild adevinwild changed the title Dashboard: Added the __BASE__ prefix to the datatable row on click fix(dashboard): Added the __BASE__ prefix to the datatable row on click - FIXES 14117 Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant