Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows,dashboard,types,fulfillment,medusa): uses requires shipping throughout lifecycle #9170

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

feat(core-flows,dashboard,types,fulfillment,medusa): uses requires shipping throughout lifecycle #9170

wants to merge 3 commits into from

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Sep 18, 2024

what:

  • uses requires shipping throughout lifecycle
test.mp4

@riqwan riqwan requested a review from a team as a code owner September 18, 2024 07:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 629be63

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 8:42am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 19, 2024 8:42am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:42am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:42am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:42am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:42am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 8:42am

fPolic
fPolic approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@fPolic fPolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work - LGTM!

...outes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx Outdated Show resolved Hide resolved
...outes/orders/order-detail/components/order-fulfillment-section/order-fulfillment-section.tsx Outdated Show resolved Hide resolved
...reate-fulfillment/components/order-create-fulfillment-form/order-create-fulfillment-form.tsx
Comment on lines +32 to +33
const [searchParams] = useSearchParams()
const requiresShipping = searchParams.get("requires_shipping")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit(non-blocking): usually we would read this in the page container and send it as a boolean prop to the form

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this one? Page container as in the route container?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, for this case in: /dashboard/src/routes/orders/order-create-fulfillment/order-create-fulfillments.tsx

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we attend to this before we merge?

packages/admin/dashboard/src/lib/rma.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fPolic fPolic fPolic approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl olivermrbl is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@riqwan @fPolic @olivermrbl