Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows, product): options checks on product create/update #9171

Merged
merged 41 commits into from
Oct 15, 2024
Merged

feat(core-flows, product): options checks on product create/update #9171

merged 41 commits into from
Oct 15, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Sep 18, 2024 •
edited
Loading

What

  • validate that variants are unique with respect to options on product update/create and variant update/create
  • validate that the product has options upon creation
  • ensure variants have the same number of option values as the product has options
  • admin error handling
  • update tests

FIXES FRMW-2707 CC-556

fPolic and others added 16 commits September 16, 2024 17:33
@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 5:09pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Oct 14, 2024 5:09pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:09pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:09pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:09pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:09pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Oct 14, 2024 5:09pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: ad01d72

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic changed the base branch from fix/check-duplicate-on-variant-create to develop September 18, 2024 16:03
@srindom srindom mentioned this pull request Oct 1, 2024
Closed
@fPolic
Merge branch 'develop' into fix/check-duplicate-on-variant-create--pr…
1ec3174 
…oduct

# Conflicts:
#	integration-tests/http/__tests__/product/admin/product.spec.ts
@fPolic fPolic changed the title feat(product): options checks on product create/update feat(core-flows, product): options checks on product create/update Oct 8, 2024
@kodiakhq kodiakhq bot merged commit 48cc00e into develop Oct 15, 2024
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/check-duplicate-on-variant-create--product branch October 15, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrien2p adrien2p adrien2p left review comments

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@christiananese christiananese Awaiting requested review from christiananese christiananese is a code owner automatically assigned from medusajs/engineering

@olivermrbl olivermrbl Awaiting requested review from olivermrbl

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fPolic @adrien2p @carlos-r-l-rodrigues @olivermrbl