Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve search to show results for all filters #9208

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

shahednasser
Copy link
Member

@shahednasser shahednasser commented Sep 20, 2024

  • If no filter is selected, show no result
  • If multiple filters are selected, show subset of results for each filter

Preview: https://docs-v2-git-docs-improve-search-filters-medusajs.vercel.app/v2

@shahednasser shahednasser requested a review from a team as a code owner September 20, 2024 09:56
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:07am
api-reference-v2 🛑 Canceled (Inspect) Sep 20, 2024 10:07am
docs-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:07am
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:07am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:07am
resources-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 10:07am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2024 10:07am

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: 60e4566

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl merged commit c790af7 into develop Sep 22, 2024
32 checks passed
@olivermrbl olivermrbl deleted the docs/improve-search-filters branch September 22, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants