fix(framework): throw when middleware fails to register

[riqwan]

what:

When middlewares fails to get registered, we swallow the error and skip registering the middlewares. This PR changes it to throw instead.

An error I encountered - I imported a function from an invalid path. Instead of the server throwing an error, the routes continued to be functional without going through the middleware.

As I did not have a logger setup, I didn't get the error log message that something went wrong.

Middlewares are pretty important piece of the route, I'd expect it to make a hard fail when it fails. wdyt?

Error after removing catch:

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
medusa-dashboard	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 20, 2024 0:54am

6 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
api-reference	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am
api-reference-v2	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am
docs-ui	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am
docs-v2	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am
medusa-docs	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am
resources-docs	⬜️ Ignored (Inspect)			Sep 20, 2024 0:54am

[changeset-bot]

⚠️ No Changeset found

Latest commit: 3b8aea4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[olivermrbl]

I think this makes sense I can't immediately think of any reasons for not throwing.

Curios if others have opinions on this.

[adrien2p]

Makes total sense 🙌