Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix referenes between store / admin types, change bigNumberValue in cart types #9217

Closed
wants to merge 1 commit into from

Conversation

shahednasser
Copy link
Member

  • Fix types referencing base entities rather than store / admin entities (mainly useful for OAS to not generate duplicate types unnecessarily, but also technically more correct)
  • Use number type instead of BigNumberValue for cart's HTTP types.

Q: Should we change usages of all BigNumberValue to number across HTTP types? From an http layer's perspective, a big number type doesn't hold a real meaning to it.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:42pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm
api-reference-v2 ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm
docs-ui ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm
docs-v2 ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm
medusa-docs ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm
resources-docs ⬜️ Ignored (Inspect) Sep 20, 2024 2:42pm

Copy link

changeset-bot bot commented Sep 20, 2024

⚠️ No Changeset found

Latest commit: b9b52a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@shahednasser shahednasser deleted the fix/http-type-references branch October 1, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant