Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing dependencies #235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dinesh-58
Copy link
Contributor

closes #225
This explicitly installs the following dependencies (that were missing for me):

  • @radix-ui/react-accordion
  • @medusajs/icons
  • @medusajs/types

Copy link

vercel bot commented Jan 9, 2024

@dinesh-58 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@@ -655,7 +655,7 @@
resolved "https://registry.yarnpkg.com/@medusajs/client-types/-/client-types-0.2.5.tgz#8baa26ca34232970a37eebd36fca93c018c447a7"
integrity sha512-jB43v+OWNSVo+9jv4EWShDKy+JGEx/LYRdcC0iS8HQx9eXNqSIsP27R8sRetdxschsuE+bd6K2Lj130DFiOICw==

"@medusajs/icons@*":
"@medusajs/icons@*", "@medusajs/icons@^1.1.0":
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this would cause any issues later on.

@dinesh-58
Copy link
Contributor Author

Might not be safe to merge this yet. I'm getting an error regarding @medusajs/types whlie deploying to Netlify. This isn't shown while building on my local machine though.

8:09:24 PM: Type error: Argument of type "import("/opt/build/repo/node_modules/@medusajs/product/node_modules/@medusajs/types/dist/product/common").ProductCollectionDTO" is not assignable to parameter of type "import("/opt/build/repo/node_modules/@medusajs/types/dist/product/common").ProductCollectionDTO".
8:09:24 PM:   Types of property "products" are incompatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to compile, cant deploy to Vercel either
1 participant