Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes: sorting and checkout #342

Merged
merged 14 commits into from
Jul 9, 2024
Merged

fixes: sorting and checkout #342

merged 14 commits into from
Jul 9, 2024

Conversation

VariableVic
Copy link
Collaborator

@VariableVic VariableVic commented Jul 4, 2024 •
edited
Loading

  1. Sorting by price is now working again, using a helper function until the order param supports sorting by price.
  2. Sorting list alignment fix.
  3. Checkout fixes:
  • Shipping address behaviour fixed
  • Made province field required
  • Shipping method selector semi-fixed. The v2 js-sdk doesn't support removing shipping methods from the cart atm, so when a user switches between shipping options a few time, we end up with a long list of methods in the cart.
  1. Made some changes to update the e2e test runner to v2, but this still needs some work.

@vercel Vercel
Copy link

vercel bot commented Jul 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nextjs-starter-medusa ❌ Failed (Inspect) Jul 5, 2024 1:29pm
storefront-v2-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 5, 2024 1:29pm

@VariableVic VariableVic merged commit 18eb439 into v2 Jul 9, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VariableVic @carlos-r-l-rodrigues