Refactor compute_midband_power
#471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gav-sturm
reviewed
Aug 29, 2025
Collaborator
gav-sturm
left a comment
gav-sturm
left a comment
There was a problem hiding this comment.
Exactly what we need in OPS. Approved!
gav-sturm
approved these changes
Sep 2, 2025
Contributor
|
Thanks for flagging this Talon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR factors out a
waveorder.focus.compute_midband_powerfunction.This function takes and returns
torch.Tensorobjects to enable this function to be used as atorchloss.@gav-sturm, I've written this PR to address your needs for OPS. Please let me know if you need additional changes.
@ieivanov, I have not changed the functionality (or tests) of the
focus_from_transverse_bandfunction, so I expect mantis' focus finding to continue working smoothly.