Updated to Pydantic V2 Models #508
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Pydantic V2 API instead of the v1 compatibility namespace (
pydantic.v1)Resources
waveorder/cli/settings.pyextra=Extra.forbidfrom inheritance, usemodel_config = ConfigDict(extra="forbid")@model_validator(mode="after")fromcls, values→self, useself.fieldinstead ofvalues.get("field"), returnself@model_validator(mode="after")(e.g.,na_det,warn_unit_consistency). Basically the changes makepydanticmodels more "dataclassy" instead of more "dictionary-y(?)"Added a few type hints as well for the individual models where I ran into them, might not be exhaustive.