Skip to content

Add usedDatabaseSize to stats, document and embeddings database metrics to index stats #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

pratts
Copy link
Contributor

@pratts pratts commented Mar 31, 2025

Pull Request

Related issue

Fixes #819 #820 #821

What does this PR do?

  • Adds usedDatabaseSize to stats
  • Adds documents database metrics to stats
  • Adds embbedings database metrics to stats

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@curquiza curquiza added the enhancement New feature or request label Apr 3, 2025
curquiza
curquiza previously approved these changes Apr 3, 2025
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank youuu

bors merge

meili-bors bot added a commit that referenced this pull request Apr 3, 2025
830: Adds usedDatabaseSize to stats, document and embeddings database metrics to index stats r=curquiza a=pratts

# Pull Request

## Related issue
Fixes #819 #820 #821 

## What does this PR do?
- Adds `usedDatabaseSize` to stats
- Adds documents database metrics to stats
- Adds embbedings database metrics to stats

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: Prateek Sharma <[email protected]>
Copy link
Contributor

meili-bors bot commented Apr 3, 2025

Build failed:

@curquiza curquiza force-pushed the add-keys-to-stats-and-index branch from f09c9d4 to 7c78721 Compare April 3, 2025 20:24
@pratts
Copy link
Contributor Author

pratts commented Apr 4, 2025

@curquiza I have updated some formatting issues that were causing the build to fail

Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

bors merge

@curquiza curquiza changed the title Adds usedDatabaseSize to stats, document and embeddings database metrics to index stats Add usedDatabaseSize to stats, document and embeddings database metrics to index stats Apr 4, 2025
Copy link
Contributor

meili-bors bot commented Apr 4, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit cfc07ea into meilisearch:main Apr 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v1.13] Add usedDatabaseSize to stats
3 participants