-
Notifications
You must be signed in to change notification settings - Fork 90
Update embedders
settings, hybrid search, and add tests for AI search methods
#1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Strift
wants to merge
26
commits into
main
Choose a base branch
from
feat/add-embedders-settings
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c125d64
Update embedders
Strift 7f61d2c
Update embedders models
Strift 93e8f69
Add docs
Strift d3aa65b
Allow updating embedders via update_settings
Strift 2fcbc47
Refactor config validation to avoid duplicate code
Strift f9258e9
Update validation code
Strift 8a4369d
Remove validation to let meilisearch handle it
Strift 742ef5e
Remove unused parameters
Strift c4e26d7
Add hybrid search
Strift 5e954ac
Add test for retrieving vectors
Strift 05291f4
Add semanticHitCount test
Strift b064b0b
Update comment
Strift d5d928e
Add test for similar documents
Strift b49cb42
Fix linters errors
Strift ef1b771
Sort imports
Strift 297b3e4
Update meilisearch/models/embedders.py
Strift c7c1700
Avoid repeating embedder type
Strift b1258c7
Remove docs
Strift 8960bc2
Add unintentionally removed
Strift 268aa4c
Fix mypy issues
Strift d8825aa
Add test for embedders fields
Strift b324323
Add tests for fields presence
Strift 057377b
Split tests
Strift 8082344
Merge branch 'main' into feat/add-embedders-settings
Strift e515f29
Fix missing imports
Strift dc98a1e
Merge branch 'main' into feat/add-embedders-settings
Strift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this handling done by Meili now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it did not trigger any test failure but it might simply be untested, so I added it back to avoid any unwanted side effects