Implement global auto-indexing switch #409
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The implementation is very straightforward, for now it only has a block form. We could add a toggle if that is useful in the future.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #409 +/- ##
==========================================
+ Coverage 89.54% 89.60% +0.05%
==========================================
Files 13 13
Lines 775 779 +4
==========================================
+ Hits 694 698 +4
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wesharper
reviewed
Mar 17, 2025
Comment on lines
+55
to
+63
| def without_auto_index(&block) | ||
| Thread.current['ms_without_auto_index_scope'] = true | ||
|
|
||
| begin | ||
| yield | ||
| ensure | ||
| Thread.current['ms_without_auto_index_scope'] = false | ||
| end | ||
| end |
|
Looks like a great add, and pretty simple implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #349