Remove legacy code in specs #414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rspec automatically adds `spec/` to the load path, and adding `lib/` to the load path does not serve a purpose from what I can see.
Also removes legacy ActiveJob test setup. This should be safe since we do not support Rails versions older than 6 anyway.
There's a theoretical possibility of a race condition: https://docs.datadoghq.com/security/code_security/static_analysis/static_analysis_rules/ruby-best-practices/atomic-file-operations/ I don't really expect it to happen, but this way is simpler in any case.
Temporary files that can be left behind if the tests don't exit gracefully.
ellnix
added
skip-changelog
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
=======================================
Coverage 90.43% 90.43%
=======================================
Files 14 14
Lines 847 847
=======================================
Hits 766 766
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the descriptions of each commit for explanations.