-
Notifications
You must be signed in to change notification settings - Fork 47
Add get documents by ids #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Index as Meilisearch::Index
participant Server as Meilisearch Server
User->>Index: documents(ids: [...], filter: opt, limit: opt)
alt filter present
Note right of Index: Build POST body { filter, ids, limit }
Index->>Server: POST /indexes/:uid/documents/fetch
else no filter
Note right of Index: Build query ?ids=...&limit=...
Index->>Server: GET /indexes/:uid/documents
end
Server-->>Index: 200 OK (documents, total)
Index-->>User: return documents object
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Assessment against linked issues
Out-of-scope changes
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #632 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 806 806
=========================================
Hits 806 806 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fefe5ed to
cb0fab8
Compare
cb0fab8 to
85a9f07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
meilisearch.gemspec (1)
21-22: Optional: Add documentation and changelog URIs for a richer gem page.Consider adding
documentation_uriandchangelog_uriso consumers can find API docs and release notes directly from RubyGems.Apply this diff to extend metadata:
s.metadata['rubygems_mfa_required'] = 'true' s.metadata['source_code_uri'] = 'https://github.com/meilisearch/meilisearch-ruby' s.metadata['bug_tracker_uri'] = 'https://github.com/meilisearch/meilisearch-ruby/issues' + s.metadata['documentation_uri'] = 'https://www.rubydoc.info/gems/meilisearch' + s.metadata['changelog_uri'] = 'https://github.com/meilisearch/meilisearch-ruby/blob/main/CHANGELOG.md'
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (3)
lib/meilisearch/index.rb(1 hunks)meilisearch.gemspec(1 hunks)spec/meilisearch/index/documents_spec.rb(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- spec/meilisearch/index/documents_spec.rb
- lib/meilisearch/index.rb
🔇 Additional comments (2)
meilisearch.gemspec (2)
19-19: No-op whitespace change.Blank line insertion is fine; no functional impact.
21-22: LGTM: Adds standard RubyGems metadata URIs.
source_code_uriandbug_tracker_uriare recognized by RubyGems and correctly point to the repo and issues.
| s.add_dependency 'httparty', '~> 0.22' | ||
|
|
||
| s.metadata['rubygems_mfa_required'] = 'true' | ||
| s.metadata['source_code_uri'] = 'https://github.com/meilisearch/meilisearch-ruby' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your contrib! <3
Pull Request
Related issue
Fixes #628
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Summary by CodeRabbit