-
Notifications
You must be signed in to change notification settings - Fork 102
chore: Bump jsonwebtoken crate to 10.0.0 #717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump jsonwebtoken crate to 10.0.0 #717
Conversation
WalkthroughUpgraded the jsonwebtoken dependency to 10.0.0 with aws_lc_rs feature enabled and default features disabled. Added a test-only Clone derive to TenantTokenClaim via cfg_attr without altering public APIs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #717 +/- ##
==========================================
+ Coverage 85.90% 85.96% +0.06%
==========================================
Files 19 19
Lines 6079 6079
==========================================
+ Hits 5222 5226 +4
+ Misses 857 853 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@curquiza Can you take a look at the changes, there are a couple more PRs waiting for the review. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors merge
|
Build succeeded:
|
Pull Request
Bump
jsonwebtokencrate to10.0.0to add the "aws_lc_rs" feature which will allow in reducing the double compilation.Related issue
Fixes #715
What does this PR do?
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!
Summary by CodeRabbit
Chores
Tests