Skip to content

Conversation

@norkunas
Copy link
Collaborator

@norkunas norkunas commented Dec 1, 2025

Pull Request

Related issue

Fixes #<issue_number>

What does this PR do?

  • Fixes PHP-CS-Fixer deprecation by using new config option instead of deprecated environment variable

PR checklist

Please check if your PR fulfills the following requirements:

  • Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • Have you read the contributing guidelines?
  • Have you made sure that the title is accurate and descriptive of the changes?

Summary by CodeRabbit

  • Chores
    • Updated code quality tooling configuration to enable processing of code targeting unsupported PHP versions.
    • Modified CI/CD workflow environment configuration for code style checking.

✏️ Tip: You can customize this high-level summary in your review settings.

@norkunas norkunas added the maintenance Anything related to maintenance (CI, tests, refactoring...) label Dec 1, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 1, 2025

Walkthrough

Configuration adjustments to PHP CS Fixer: removal of an environment override from the GitHub Actions workflow and addition of setUnsupportedPhpVersionAllowed(true) method call to the local PHP CS Fixer configuration file.

Changes

Cohort / File(s) Summary
PHP CS Fixer Configuration
\\.github/workflows/tests.yml, \\.php-cs-fixer.dist.php
Removed PHP_CS_FIXER_IGNORE_ENV environment variable from the code-style job and added setUnsupportedPhpVersionAllowed(true) to the PHP CS Fixer config to enable processing of code targeting unsupported PHP versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify the rationale for allowing unsupported PHP versions and its implications for the project's PHP version targeting strategy

Suggested reviewers

  • curquiza

Poem

🐰 With whiskers twitched and paws held high,
Config files now harmonize!
No ENV to override the way,
CS Fixer hops with PHP, hooray!

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix PHP-CS-Fixer deprecation' accurately and concisely summarizes the main change: addressing a PHP-CS-Fixer deprecation by replacing a deprecated environment variable with a new configuration option.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a421ae9 and b857d59.

📒 Files selected for processing (2)
  • .github/workflows/tests.yml (0 hunks)
  • .php-cs-fixer.dist.php (1 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/tests.yml
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: norkunas
Repo: meilisearch/meilisearch-symfony PR: 391
File: src/Command/MeilisearchImportCommand.php:117-120
Timestamp: 2025-08-05T04:46:01.119Z
Learning: In meilisearch-symfony project, the maintainer norkunas prefers to keep PRs focused and defer error handling improvements for settings updates to separate PRs, particularly when it involves decisions about partial import behavior when some indexes fail.
🔇 Additional comments (1)
.php-cs-fixer.dist.php (1)

12-12: New setUnsupportedPhpVersionAllowed(true) correctly replaces the deprecated env override

This is the right PhpCsFixer‑level replacement for PHP_CS_FIXER_IGNORE_ENV=1, and its placement in the fluent config chain is fine. Only thing to double‑check is that the dev dependency version of friendsofphp/php-cs-fixer in your composer.* files is new enough to support setUnsupportedPhpVersionAllowed(), but otherwise this looks good and keeps the PR nicely scoped to the deprecation fix. Based on learnings, this stays focused on the specific maintenance task.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@norkunas norkunas marked this pull request as ready for review December 1, 2025 05:30
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.38%. Comparing base (71f6bea) to head (b857d59).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   88.38%   88.38%           
=======================================
  Files          20       20           
  Lines         878      878           
=======================================
  Hits          776      776           
  Misses        102      102           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@norkunas norkunas merged commit d96d4aa into meilisearch:main Dec 1, 2025
28 checks passed
@norkunas norkunas deleted the fix-deprecation branch December 1, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Anything related to maintenance (CI, tests, refactoring...)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant