Skip to content

Conversation

@FelonEkonom
Copy link
Member

No description provided.

@FelonEkonom FelonEkonom self-assigned this Mar 7, 2025
@FelonEkonom FelonEkonom moved this to In Progress in Smackore Mar 7, 2025
@FelonEkonom FelonEkonom marked this pull request as ready for review March 12, 2025 15:19
@FelonEkonom FelonEkonom requested a review from varsill March 12, 2025 15:19
mix.exs Outdated
Comment on lines 41 to 42
{:membrane_core,
github: "membraneframework/membrane_core", branch: "changes-in-connector", override: true},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to remove branch dependency before merging ;)

Comment on lines +23 to +24
link_builder
|> child(%Membrane.H264.Parser{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NIT] Now it's inconsistent with other clauses, which don't use pipe operator, but leave it as you like

@FelonEkonom FelonEkonom merged commit 2ae23dd into master Mar 14, 2025
3 checks passed
@FelonEkonom FelonEkonom deleted the allow-format-changes branch March 14, 2025 14:45
@github-project-automation github-project-automation bot moved this from In Progress to Done in Smackore Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants