Add domain models and review OQL documentation #9914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkvanMents
commented
Jul 25, 2025
| @@ -111,15 +115,15 @@ The following query returns all attributes of objects of `Sales.Request` that ar | |||
| ``` | |||
| SELECT Sales.Request/* | |||
| FROM Sales.Customer | |||
| JOIN Sales.Customer/Sales.Customer_Request/Sales.Request | |||
| JOIN Sales.Customer/Sales.Request_Customer/Sales.Request | |||
There was a problem hiding this comment.
I think this was back to front naming?
| @@ -544,7 +548,7 @@ Where `expression` is an expression of any datatype. | |||
| The `IS` operator can be used to filter out rows with values that are NULL. For example: | |||
|
|
|||
| ```sql | |||
| SELECT Revenue, Cost FROM Sales.Finance WHERE Revenue IS NOT NULL | |||
| SELECT Revenue, Cost FROM Sales.Finances WHERE Revenue IS NOT NULL | |||
There was a problem hiding this comment.
Typo - the other examples used "Finances"
| @@ -1141,18 +1145,18 @@ For example, a space delimited list can be converted to one with commas to be us | |||
| SELECT * FROM Sales.Raw | |||
| ``` | |||
|
|
|||
| | ID | Import | | |||
| | ID | RawImport | | |||
There was a problem hiding this comment.
"Import" is an invalid attribute name
| @@ -173,7 +177,7 @@ SELECT MAX(Stock) as StockMax FROM Sales.Product | |||
| To return the name(s) of the product(s) with the highest stock level you have to use a subquery. The subquery returns the maximum stock number, which is then compared to each product's stock in the `WHERE` clause: | |||
|
|
|||
| ```sql | |||
| SELECT HighestStockProductName FROM Sales.Product | |||
| SELECT Name AS HighestStockProductName FROM Sales.Product | |||
There was a problem hiding this comment.
I think we want to pick up Name here but report it as "HighestStockProductName"
There was a problem hiding this comment.
Not sure about this - what is the relationship between Storage and Location?
I think the example works with this, but not convinced that the example gives a meaningful answer?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.