Moo 1800/update dependencies #262
Open
+249
−354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
April 10, 2025 09:47
packages/jsActions/mobile-resources-native/src/authentication/BiometricAuthentication.ts
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/notifications/CancelAllScheduledNotifications.ts
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/notifications/DisplayNotification.ts
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/notifications/DisplayNotification.ts
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/notifications/DisplayNotification.ts
Outdated
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/notifications/ScheduleNotification.ts
Outdated
Show resolved
Hide resolved
packages/jsActions/mobile-resources-native/src/platform/PlaySound.ts
Outdated
Show resolved
Hide resolved
packages/pluggableWidgets/background-gradient-native/src/BackgroundGradient.tsx
Outdated
Show resolved
Hide resolved
vadymv-mendix
previously approved these changes
Apr 24, 2025
| } | ||
|
|
||
| const notification = { message: body } as PushNotificationObject; | ||
| const channelId = "mendix-local-notifications"; | ||
| await createNotificationChannelIfNeeded(channelId); |
There was a problem hiding this comment.
Given that the channel is Android specific I'd call this function only when we're running on Android.
| return Promise.reject(new Error("Notifications module is not available in your app")); | ||
| } | ||
| const channelId = "mendix-local-notifications"; | ||
| await createNotificationChannelIfNeeded(channelId); |
There was a problem hiding this comment.
Same here, it's applicable only to Android so we need to add a platform check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr, I've updated the following dependencies.
react-native-push-notification ( migrated to notifee )
@react-native-community/push-notification-ios ( mgirated to notifee )
react-native-device-info
react-native-sound ( migrated to track-player )
react-native-linear-gradient