[WC-2835]: RTE implementation of Quill-Table-Better #1506
Conversation
samuelreichert
force-pushed
the
feat/WC-2835-RTE-table
branch
3 times, most recently
from
a42830a to
3a4ce62
Compare
samuelreichert
force-pushed
the
feat/WC-2835-RTE-table
branch
from
3a4ce62 to
8b801ae
Compare
| leftIcon.setAttribute("src", left); | ||
| dropDown.appendChild(leftIcon); | ||
| if (isDropDown) { | ||
| const rightIcon = document.createElement("img"); |
There was a problem hiding this comment.
seems like it is possible to not use svg and use rich text font icons here.
i have notify Ana to update RTE font icons.
and we can reduce bundle size
| } | ||
|
|
||
| createMenu(left: string, right: string, isDropDown: boolean) { | ||
| const container = document.createElement("div"); |
There was a problem hiding this comment.
update all document into this.quill.root.ownerDocument or this.root.ownerDocument
this is safer if rich text being put into iframe.
| const EXTRA: MenusDefaults = { | ||
| copy: { | ||
| content: useLanguage("copyTable"), | ||
| icon: copyIcon, |
There was a problem hiding this comment.
if using RTE font icons, this probably changed into iconClassName
| } | ||
|
|
||
| createDragTable(table: Element) { | ||
| const dragTable = document.createElement("div"); |
There was a problem hiding this comment.
same here, change document into ownerDocument
| : false | ||
| table: false, | ||
| "table-better": { | ||
| language: "en_US", |
There was a problem hiding this comment.
we are using hardcoded language here.
let's confirm with @takumagott first.
otherwise, we can use ownerDocument.documentElement.lang to check for browser's language.
but note that we don't support all languages.
Pull request type
Description