[WC-2835]: RTE implementation of Quill-Table-Better #1506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

gjulivan merged 28 commits into main from feat/WC-2835-RTE-table

Apr 22, 2025

Contributor

samuelreichert commented Mar 19, 2025

Pull request type

Description

github-actions bot added the rich-text-web label

samuelreichert force-pushed the feat/WC-2835-RTE-table branch 3 times, most recently from a42830a to 3a4ce62 Compare

March 24, 2025 08:28

samuelreichert force-pushed the feat/WC-2835-RTE-table branch from 3a4ce62 to 8b801ae Compare

March 27, 2025 15:40

samuelreichert marked this pull request as ready for review

March 28, 2025 08:40

samuelreichert requested a review from a team as a code owner

March 28, 2025 08:40

gjulivan reviewed

View reviewed changes

packages/pluggableWidgets/rich-text-web/src/utils/formats/quill-table-better/ui/table-menus.ts Outdated Show resolved Hide resolved

gjulivan reviewed

View reviewed changes

packages/pluggableWidgets/rich-text-web/src/utils/formats/quill-table-better/ui/table-menus.ts Outdated Show resolved Hide resolved

gjulivan reviewed

View reviewed changes

packages/pluggableWidgets/rich-text-web/src/utils/formats/quill-table-better/ui/table-menus.ts Outdated Show resolved Hide resolved

gjulivan reviewed

View reviewed changes

packages/pluggableWidgets/rich-text-web/src/utils/formats/quill-table-better/ui/operate-line.ts Outdated Show resolved Hide resolved

gjulivan reviewed

View reviewed changes

packages/pluggableWidgets/rich-text-web/src/components/Editor.tsx Show resolved Hide resolved

samuelreichert force-pushed the feat/WC-2835-RTE-table branch 2 times, most recently from ec3f9c0 to 27df955 Compare

April 9, 2025 12:29

gjulivan previously approved these changes

View reviewed changes

samuelreichert dismissed gjulivan’s stale review via

e6ff090

April 10, 2025 08:02

samuelreichert force-pushed the feat/WC-2835-RTE-table branch 2 times, most recently from 4287b89 to 78d35dd Compare

April 15, 2025 12:50

gjulivan and others added 12 commits

April 17, 2025 13:16


          chore: add better table

860abac


          fix: wip - update quill-table-better files

9c06976


          fix(table-better): add ts no check on external files

6e57504


          feat(table-better): update how svg files are added to DOM

874ee0f


          feat(table-better): improve table-better modal positioning with float…

3417ddd

…ing-ui


          feat(table-better): add table icon on toolbar

34ec963


          feat(table-better): change iro to coloris colorpicker

40899ab


          feat(table-better): add lodash.merge

c20198f


          feat(rich-text): add toolbar keys for font size and table

15f5429


          feat(table-better): small improvements on table-better

15f992f


          feat(rich-text): update rollup config for table-better support

319f1e8


          fix: eslint error fix

fe075ae

samuelreichert and others added 13 commits

April 17, 2025 13:16


          test(rich-text): update failing snapshot

671b0f9


          fix(quill-table-better): replace document event listeners with quill.…

3e8aa02

…root event listeners


          feat(rich-text): add new icons to RichTextIcons.scss

b533097


          fix(table-better): replace SVG icons with CSS classes for table menus…

9b6de57

… and properties


          fix(quill-table-better): remove unused SVG icons for table formatting

e341939


          fix(rich-text): update RichTextIconFont.woff2 to improve icon rendering

cc560aa


          fix(rich-text): add quill-table-better to ignored files in ESLint config


          test(rich-text): update e2e screenshot

ee8b636


          feat(rich-text): add tableBetter property to custom basic mode

d004ef0


          feat(quill-table-better): add dropdown icon separately to table prope…

4e69f80

…rties form


          fix(table-better): update event listeners to use window.document for …

b62fa11

…drag operations


          feat(table-better): enhance menu item structure by adding an icon con…

b8612f1

…tainer


          fix(rich-text): ensure tableBetter property is set in default props

873d8fd

samuelreichert force-pushed the feat/WC-2835-RTE-table branch from 6cd4f6c to 873d8fd Compare

April 17, 2025 11:16


          test(rich-text): update e2e screenshot custom mode

cd54ec0

leonardomendix previously approved these changes

View reviewed changes

gjulivan previously approved these changes

View reviewed changes

samuelreichert added 2 commits

April 18, 2025 10:02


          chore(changelog): add entry for table support in Rich Text

ee560eb


          chore: update version to 4.6.0

64143dd

samuelreichert dismissed stale reviews from gjulivan and leonardomendix via

64143dd

April 18, 2025 08:02

gjulivan approved these changes

View reviewed changes

r0b1n approved these changes

View reviewed changes

gjulivan merged commit b042f0c into main

16 checks passed

gjulivan deleted the feat/WC-2835-RTE-table branch

April 22, 2025 08:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels