-
Notifications
You must be signed in to change notification settings - Fork 52
[WC-3015] Improve dropdown filter #1732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
r0b1n
wants to merge
23
commits into
main
Choose a base branch
from
improve-dropdown-filter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
c37682e
chore: fix styling
r0b1n 03e37b7
chore: remove unused separator, it is done via css
r0b1n 14bb6a8
chore: multi select never has empty item
r0b1n c449b0a
fix: don't focus on input when clear button clicked
r0b1n 1445e26
fix: add focus highlight for clear button
r0b1n ee9f4ac
chore: restructure select html layout, don't use button, move toggle …
r0b1n 4fcf851
chore: improve selected tag visibility
r0b1n cc9a90f
chore: do not close popup if already open and input is clicked
r0b1n 5b33e29
chore: activate widget on clicking on the whole widget area
r0b1n 28b31fe
chore: focus on tags when left arrow of backspace is clicked with cur…
r0b1n abf0ac9
chore: shrink input when there is no focus, prevents empty line when …
r0b1n f3215b7
feat: rework captions
r0b1n ddbbc5b
fix: don't close popup on click
r0b1n 96158ad
fix: update e2e tests
r0b1n 83eac1a
fix: aria label issue for dropdown selectors
r0b1n 17b182c
chore: add release notes and bump version
r0b1n 4c46ef0
fix: focusing issues after clear
r0b1n f2406f3
chore: fix screenshots
r0b1n d19bd5e
fix: don't select item on blur, allow down arrow key on clear button
r0b1n 8b37ec3
chore: more e2e fixes
r0b1n 2e8fa92
fix: keeping it open is not needed as Clear btn stop click propagation
r0b1n 7b0ca7a
fix: use label (not value) as label, makes more sense for SR UX
r0b1n 7ded2df
chore: fix gallery a11y caption
r0b1n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-126 Bytes
(99%)
.../e2e/DataGridDateFilter.spec.js-snapshots/dataGridDateFilter-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-717 Bytes
(98%)
...ownFilter.spec.js-snapshots/dataGridDropDownFilter-undefined-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.