Skip to content

Test/remove enzyme from widgets #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Test/remove enzyme from widgets #1736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
088999d
test(fieldset-web): remove enzyme from fieldset widget
samuelreichert Jun 27, 2025
b9884a9
fix: wip
samuelreichert Jun 30, 2025
e4e709d
chore: update test scripts to use enzyme-free configuration across mu…
samuelreichert Jul 8, 2025
3333efe
test(image-web): update tests and snapshots for enzyme-free configura…
samuelreichert Jul 8, 2025
2e292c8
test(progress-bar-web): update tests to use testing-library and remov…
samuelreichert Jul 8, 2025
59d1b1d
test(maps-web): update tests from ts to tsx and remove enzyme
samuelreichert Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/barcode-scanner-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"publish-marketplace": "rui-publish-marketplace",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
3 changes: 1 addition & 2 deletions packages/pluggableWidgets/calendar-web/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const { join } = require("path");
const base = require("@mendix/pluggable-widgets-tools/test-config/jest.config");
const base = require("@mendix/pluggable-widgets-tools/test-config/jest.enzyme-free.config.js");

module.exports = {
...base,
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/chart-playground-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"publish-marketplace": "rui-publish-marketplace",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/fieldset-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"publish-marketplace": "rui-publish-marketplace",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
11 changes: 6 additions & 5 deletions packages/pluggableWidgets/fieldset-web/src/__tests__/Fieldset.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { shallow } from "enzyme";
import "@testing-library/jest-dom";
import { render } from "@testing-library/react";
import { createElement, Fragment, ReactNode } from "react";

import { Fieldset, FieldsetProps } from "../components/Fieldset";
Expand All @@ -20,17 +21,17 @@ describe("Fieldset", () => {
);

it("renders children and legend", () => {
const fieldset = shallow(<Fieldset {...defaultFieldsetProps}>{defaultChildren}</Fieldset>);
const fieldset = render(<Fieldset {...defaultFieldsetProps}>{defaultChildren}</Fieldset>);

expect(fieldset).toMatchSnapshot();
expect(fieldset.asFragment()).toMatchSnapshot();
});
it("renders only children when no legend is passed", () => {
const fieldset = shallow(
const fieldset = render(
<Fieldset {...defaultFieldsetProps} legend={undefined}>
{defaultChildren}
</Fieldset>
);

expect(fieldset).toMatchSnapshot();
expect(fieldset.asFragment()).toMatchSnapshot();
});
});
68 changes: 35 additions & 33 deletions packages/pluggableWidgets/fieldset-web/src/__tests__/__snapshots__/Fieldset.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,40 +1,42 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Fieldset renders children and legend 1`] = `
<fieldset
className="className"
name="fieldset"
style={{}}
tabIndex={0}
>
<legend>
legend
</legend>
<label>
Name:
</label>
<input
id="employee_name"
name="employee_name"
type="text"
/>
</fieldset>
<DocumentFragment>
<fieldset
class="className"
name="fieldset"
tabindex="0"
>
<legend>
legend
</legend>
<label>
Name:
</label>
<input
id="employee_name"
name="employee_name"
type="text"
/>
</fieldset>
</DocumentFragment>
`;

exports[`Fieldset renders only children when no legend is passed 1`] = `
<fieldset
className="className"
name="fieldset"
style={{}}
tabIndex={0}
>
<label>
Name:
</label>
<input
id="employee_name"
name="employee_name"
type="text"
/>
</fieldset>
<DocumentFragment>
<fieldset
class="className"
name="fieldset"
tabindex="0"
>
<label>
Name:
</label>
<input
id="employee_name"
name="employee_name"
type="text"
/>
</fieldset>
</DocumentFragment>
`;
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/file-uploader-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"release": "pluggable-widgets-tools release:web",
"remove-nf-defaults": "node nf-defaults.mjs remove",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/gallery-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"lint": "eslint src/ package.json",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/html-element-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"publish-marketplace": "rui-publish-marketplace",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/pluggableWidgets/image-web/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"publish-marketplace": "rui-publish-marketplace",
"release": "pluggable-widgets-tools release:web",
"start": "pluggable-widgets-tools start:server",
"test": "pluggable-widgets-tools test:unit:web",
"test": "pluggable-widgets-tools test:unit:web:enzyme-free",
"update-changelog": "rui-update-changelog-widget",
"verify": "rui-verify-package-format"
},
Expand Down
8 changes: 6 additions & 2 deletions packages/pluggableWidgets/image-web/src/components/Image/ui.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ function ContentIcon(props: ImageContentIcon): ReactElement {
"aria-label": props.altText,
role: "img"
}
: {};
: {
role: "img"
};

const onClickProps = getImageContentOnClickProps(props.onClick, props.tabIndex);

Expand Down Expand Up @@ -103,7 +105,9 @@ function getImageContentOnClickProps(
tabIndex?: number
): HTMLAttributes<HTMLElement> {
if (!onClick) {
return {};
return {
role: "img"
};
}
return {
onClick,
Expand Down
Loading
Loading